Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema cleanup and bugfixes #343

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Apr 4, 2023

Committer Notes

This set of changes are to cleanup a variety schemas.

  • Fixes a bug in the base64 data type that caused by most of the allowed alphabet to be excluded as well as padding characters.
  • Corrected duration-based patterns to enforce the correct semantics.
  • Simplified boolean patterns.
  • Aligned integer and string data type derivations.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@aj-stein-nist aj-stein-nist changed the title Schema cleanup and bufixes Schema cleanup and bugfixes Apr 4, 2023
wendellpiez
wendellpiez previously approved these changes Apr 4, 2023
Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aj-stein-nist
aj-stein-nist previously approved these changes Apr 4, 2023
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions below :)

schema/json/metaschema-datatypes.json Outdated Show resolved Hide resolved
@aj-stein-nist
Copy link
Collaborator

Is it ok I request a rebase against current develop to include #344 to make testing easier? I work around it, but it would be minorly helpful. :-)

@david-waltermire
Copy link
Collaborator Author

Is it ok I request a rebase against current develop to include #344 to make testing easier? I work around it, but it would be minorly helpful. :-)

Done.

@david-waltermire
Copy link
Collaborator Author

I believe this PR is ready to merge. I'll merge it once @nikitawootten-nist approves.

@david-waltermire david-waltermire merged commit 58940d4 into develop Apr 14, 2023
@david-waltermire david-waltermire deleted the schema-cleanup-and-bugfixes branch April 14, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants